Skip to content

feat: add rekor, rekor-monitor and rekor-search applications#263

Merged
osmman merged 1 commit intomainfrom
cac-rekor-apps
Oct 21, 2025
Merged

feat: add rekor, rekor-monitor and rekor-search applications#263
osmman merged 1 commit intomainfrom
cac-rekor-apps

Conversation

@osmman
Copy link
Contributor

@osmman osmman commented Oct 20, 2025

Summary by Sourcery

Add and integrate three new AppStudio applications (rekor, rekor-monitor, and rekor-search) along with their Component and ImageRepository definitions, update base kustomization to include them, remove outdated overlays, and scaffold common overlay components for enterprise contract and promote-to-candidate.

New Features:

  • Add rekor Application, Component, and ImageRepository resources to support rekor, rekor-cli, rekor-server, and backfill-redis
  • Introduce rekor-monitor Application, Component, and ImageRepository resources
  • Introduce rekor-search Application, Component, and ImageRepository resources

Enhancements:

  • Integrate the new applications into the base kustomization manifest
  • Remove stale promote-to-candidate overlays for rekor, rekor-monitor, and rekor-search
  • Scaffold reusable kustomize overlay components for enterprise contract and release plan

@sourcery-ai
Copy link

sourcery-ai bot commented Oct 20, 2025

Reviewer's Guide

This PR integrates three new applications—rekor, rekor-monitor, and rekor-search—into the base kustomize configuration by extending resource lists, scaffolding their Component, ImageRepository, and Application manifests, and cleaning up stale promote-to-candidate overlays.

Entity relationship diagram for new ImageRepository resources

erDiagram
  APPLICATION ||--o| COMPONENT : has
  COMPONENT ||--o| IMAGEREPOSITORY : builds
  APPLICATION {
    string name
    string displayName
  }
  COMPONENT {
    string name
    string componentName
    string source_git_url
    string source_git_revision
    string source_dockerfileUrl
  }
  IMAGEREPOSITORY {
    string name
    string image_name
    string image_visibility
    string notifications_config_url
    string notifications_event
    string notifications_method
    string notifications_title
  }
Loading

Class diagram for new Component and ImageRepository manifests

classDiagram
  class Application {
    +name: string
    +displayName: string
  }
  class Component {
    +name: string
    +componentName: string
    +source.git.url: string
    +source.git.revision: string
    +source.dockerfileUrl: string
  }
  class ImageRepository {
    +name: string
    +image.name: string
    +image.visibility: string
    +notifications.config.url: string
    +notifications.event: string
    +notifications.method: string
    +notifications.title: string
  }
  Application "1" -- "*" Component : contains
  Component "1" -- "1" ImageRepository : builds
Loading

File-Level Changes

Change Details Files
Extend base application kustomization to include new rekor apps
  • Comment out legacy konflux/pipelines entries
  • Add rekor/base, rekor-monitor/base, rekor-search/base to resources
konflux-configs/base/application/kustomization.yaml
Remove outdated promote-to-candidate overlays for rekor apps
  • Drop rekor, rekor-search, rekor-monitor entries from overlay resources
  • Delete overlay kustomization.yaml and patch.yaml for each app
konflux-configs/base/release-plan/promote-to-candidate/components/overlays/kustomization.yaml
konflux-configs/base/release-plan/promote-to-candidate/components/overlays/rekor-monitor/*
konflux-configs/base/release-plan/promote-to-candidate/components/overlays/rekor-search/*
konflux-configs/base/release-plan/promote-to-candidate/components/overlays/rekor/*
Add new Component definitions for rekor services
  • Define backfill-redis, rekor-cli, rekor-server Components
  • Define rekor-monitor and rekor-search Components with Git source and Docker pipeline annotations
konflux-configs/base/application/rekor/base/component.yaml
konflux-configs/base/application/rekor-monitor/base/component.yaml
konflux-configs/base/application/rekor-search/base/component.yaml
Introduce ImageRepository resources for each component
  • Create imagerepository-for-rekor-backfill-redis, rekor-cli, rekor-server
  • Create imagerepository-for-rekor-monitor and rekor-search with SBOM webhook notifications
konflux-configs/base/application/rekor/base/imagerepository.yaml
konflux-configs/base/application/rekor-monitor/base/imagerepository.yaml
konflux-configs/base/application/rekor-search/base/imagerepository.yaml
Scaffold Application manifests and kustomizations for all new apps
  • Add application.yaml with displayName for each app
  • Add base kustomization.yaml pulling in component and imagerepository
  • Wire in shared base/application overlay
konflux-configs/base/application/rekor/base/application.yaml
konflux-configs/base/application/rekor/base/kustomization.yaml
konflux-configs/base/application/rekor-monitor/base/application.yaml
konflux-configs/base/application/rekor-monitor/base/kustomization.yaml
konflux-configs/base/application/rekor-search/base/application.yaml
konflux-configs/base/application/rekor-search/base/kustomization.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Signed-off-by: Tomas Turek <tturek@redhat.com>
@github-actions
Copy link

github-actions bot commented Oct 20, 2025

Configuration Diff

16 document(s) impacted:

+ 16 added
- 0 removed
! 0 modified
Diff
@@ (root level) @@
# appstudio.redhat.com/v1alpha1/Application/rhtas-tenant/rekor
! + one document added:
+   ---
+   apiVersion: appstudio.redhat.com/v1alpha1
+   kind: Application
+   metadata:
+     name: rekor
+     namespace: rhtas-tenant
+   spec:
+     displayName: "rekor (main)"

@@ (root level) @@
# appstudio.redhat.com/v1alpha1/Application/rhtas-tenant/rekor-monitor
! + one document added:
+   ---
+   apiVersion: appstudio.redhat.com/v1alpha1
+   kind: Application
+   metadata:
+     name: rekor-monitor
+     namespace: rhtas-tenant
+   spec:
+     displayName: "rekor-monitor (main)"

@@ (root level) @@
# appstudio.redhat.com/v1alpha1/Application/rhtas-tenant/rekor-search
! + one document added:
+   ---
+   apiVersion: appstudio.redhat.com/v1alpha1
+   kind: Application
+   metadata:
+     name: rekor-search
+     namespace: rhtas-tenant
+   spec:
+     displayName: "rekor-search (main)"

@@ (root level) @@
# appstudio.redhat.com/v1alpha1/Component/rhtas-tenant/backfill-redis
! + one document added:
+   ---
+   apiVersion: appstudio.redhat.com/v1alpha1
+   kind: Component
+   metadata:
+     name: backfill-redis
+     namespace: rhtas-tenant
+     annotations:
+       build.appstudio.openshift.io/pipeline: "{\"name\":\"docker-build-oci-ta\",\"bundle\":\"latest\"}"
+       git-provider: github
+       git-provider-url: "https://github.com"
+   spec:
+     source:
+       git:
+         url: "https://github.com/securesign/rekor"
+         context: ./
+         dockerfileUrl: Dockerfile.backfill-redis.rh
+         revision: main
+     application: rekor
+     componentName: backfill-redis

@@ (root level) @@
# appstudio.redhat.com/v1alpha1/Component/rhtas-tenant/rekor-cli
! + one document added:
+   ---
+   apiVersion: appstudio.redhat.com/v1alpha1
+   kind: Component
+   metadata:
+     name: rekor-cli
+     namespace: rhtas-tenant
+     annotations:
+       build.appstudio.openshift.io/pipeline: "{\"name\":\"docker-build-oci-ta\",\"bundle\":\"latest\"}"
+       git-provider: github
+       git-provider-url: "https://github.com"
+   spec:
+     source:
+       git:
+         url: "https://github.com/securesign/rekor"
+         context: ./
+         dockerfileUrl: Dockerfile.rekor-cli.rh
+         revision: main
+     application: rekor
+     componentName: rekor-cli

@@ (root level) @@
# appstudio.redhat.com/v1alpha1/Component/rhtas-tenant/rekor-monitor
! + one document added:
+   ---
+   apiVersion: appstudio.redhat.com/v1alpha1
+   kind: Component
+   metadata:
+     name: rekor-monitor
+     namespace: rhtas-tenant
+     annotations:
+       build.appstudio.openshift.io/pipeline: "{\"name\":\"docker-build-oci-ta\",\"bundle\":\"latest\"}"
+       git-provider: github
+       git-provider-url: "https://github.com"
+   spec:
+     source:
+       git:
+         url: "https://github.com/securesign/rekor-monitor"
+         dockerfileUrl: Dockerfile.rh
+         revision: main
+     application: rekor-monitor
+     componentName: rekor-monitor

@@ (root level) @@
# appstudio.redhat.com/v1alpha1/Component/rhtas-tenant/rekor-search
! + one document added:
+   ---
+   apiVersion: appstudio.redhat.com/v1alpha1
+   kind: Component
+   metadata:
+     name: rekor-search
+     namespace: rhtas-tenant
+     annotations:
+       build.appstudio.openshift.io/pipeline: "{\"name\":\"docker-build-oci-ta\",\"bundle\":\"latest\"}"
+       git-provider: github
+       git-provider-url: "https://github.com"
+   spec:
+     source:
+       git:
+         url: "https://github.com/securesign/rekor-search-ui"
+         dockerfileUrl: Dockerfile
+         revision: main
+     application: rekor-search
+     componentName: rekor-search

@@ (root level) @@
# appstudio.redhat.com/v1alpha1/Component/rhtas-tenant/rekor-server
! + one document added:
+   ---
+   apiVersion: appstudio.redhat.com/v1alpha1
+   kind: Component
+   metadata:
+     name: rekor-server
+     namespace: rhtas-tenant
+     annotations:
+       build.appstudio.openshift.io/pipeline: "{\"name\":\"docker-build-oci-ta\",\"bundle\":\"latest\"}"
+       git-provider: github
+       git-provider-url: "https://github.com"
+   spec:
+     source:
+       git:
+         url: "https://github.com/securesign/rekor"
+         context: ./
+         dockerfileUrl: Dockerfile.rekor-server.rh
+         revision: main
+     application: rekor
+     componentName: rekor-server

@@ (root level) @@
# appstudio.redhat.com/v1alpha1/ImageRepository/rhtas-tenant/imagerepository-for-rekor-backfill-redis
! + one document added:
+   ---
+   apiVersion: appstudio.redhat.com/v1alpha1
+   kind: ImageRepository
+   metadata:
+     name: imagerepository-for-rekor-backfill-redis
+     namespace: rhtas-tenant
+     labels:
+       appstudio.redhat.com/application: rekor
+       appstudio.redhat.com/component: backfill-redis
+   spec:
+     image:
+       name: rhtas-tenant/backfill-redis
+       visibility: public
+     notifications:
+     - config:
+         url: "https://bombino.api.redhat.com/v1/sbom/quay/push"
+       event: repo_push
+       method: webhook
+       title: SBOM-event-to-Bombino

@@ (root level) @@
# appstudio.redhat.com/v1alpha1/ImageRepository/rhtas-tenant/imagerepository-for-rekor-monitor-rekor-monitor
! + one document added:
+   ---
+   apiVersion: appstudio.redhat.com/v1alpha1
+   kind: ImageRepository
+   metadata:
+     name: imagerepository-for-rekor-monitor-rekor-monitor
+     namespace: rhtas-tenant
+     labels:
+       appstudio.redhat.com/application: rekor-monitor
+       appstudio.redhat.com/component: rekor-monitor
+   spec:
+     image:
+       name: rhtas-tenant/rekor-monitor
+       visibility: public
+     notifications:
+     - config:
+         url: "https://bombino.api.redhat.com/v1/sbom/quay/push"
+       event: repo_push
+       method: webhook
+       title: SBOM-event-to-Bombino

@@ (root level) @@
# appstudio.redhat.com/v1alpha1/ImageRepository/rhtas-tenant/imagerepository-for-rekor-rekor-cli
! + one document added:
+   ---
+   apiVersion: appstudio.redhat.com/v1alpha1
+   kind: ImageRepository
+   metadata:
+     name: imagerepository-for-rekor-rekor-cli
+     namespace: rhtas-tenant
+     labels:
+       appstudio.redhat.com/application: rekor
+       appstudio.redhat.com/component: rekor-cli
+   spec:
+     image:
+       name: rhtas-tenant/rekor-cli
+       visibility: public
+     notifications:
+     - config:
+         url: "https://bombino.api.redhat.com/v1/sbom/quay/push"
+       event: repo_push
+       method: webhook
+       title: SBOM-event-to-Bombino

@@ (root level) @@
# appstudio.redhat.com/v1alpha1/ImageRepository/rhtas-tenant/imagerepository-for-rekor-rekor-server
! + one document added:
+   ---
+   apiVersion: appstudio.redhat.com/v1alpha1
+   kind: ImageRepository
+   metadata:
+     name: imagerepository-for-rekor-rekor-server
+     namespace: rhtas-tenant
+     labels:
+       appstudio.redhat.com/application: rekor
+       appstudio.redhat.com/component: rekor-server
+   spec:
+     image:
+       name: rhtas-tenant/rekor-server
+       visibility: public
+     notifications:
+     - config:
+         url: "https://bombino.api.redhat.com/v1/sbom/quay/push"
+       event: repo_push
+       method: webhook
+       title: SBOM-event-to-Bombino

@@ (root level) @@
# appstudio.redhat.com/v1alpha1/ImageRepository/rhtas-tenant/imagerepository-for-rekor-search-rekor-search
! + one document added:
+   ---
+   apiVersion: appstudio.redhat.com/v1alpha1
+   kind: ImageRepository
+   metadata:
+     name: imagerepository-for-rekor-search-rekor-search
+     namespace: rhtas-tenant
+     labels:
+       appstudio.redhat.com/application: rekor-search
+       appstudio.redhat.com/component: rekor-search
+   spec:
+     image:
+       name: rhtas-tenant/rekor-search
+       visibility: public
+     notifications:
+     - config:
+         url: "https://bombino.api.redhat.com/v1/sbom/quay/push"
+       event: repo_push
+       method: webhook
+       title: SBOM-event-to-Bombino

@@ (root level) @@
# appstudio.redhat.com/v1beta2/IntegrationTestScenario/rhtas-tenant/rekor-enterprise-contract
! + one document added:
+   ---
+   apiVersion: appstudio.redhat.com/v1beta2
+   kind: IntegrationTestScenario
+   metadata:
+     name: rekor-enterprise-contract
+     namespace: rhtas-tenant
+     annotations:
+       test.appstudio.openshift.io/kind: enterprise-contract
+   spec:
+     application: rekor
+     resolverRef:
+       params:
+       - name: url
+         value: "https://github.com/konflux-ci/build-definitions"
+       - name: revision
+         value: main
+       - name: pathInRepo
+         value: pipelines/enterprise-contract.yaml
+       resolver: git
+       resourceKind: pipeline

@@ (root level) @@
# appstudio.redhat.com/v1beta2/IntegrationTestScenario/rhtas-tenant/rekor-monitor-enterprise-contract
! + one document added:
+   ---
+   apiVersion: appstudio.redhat.com/v1beta2
+   kind: IntegrationTestScenario
+   metadata:
+     name: rekor-monitor-enterprise-contract
+     namespace: rhtas-tenant
+     annotations:
+       test.appstudio.openshift.io/kind: enterprise-contract
+   spec:
+     application: rekor-monitor
+     resolverRef:
+       params:
+       - name: url
+         value: "https://github.com/konflux-ci/build-definitions"
+       - name: revision
+         value: main
+       - name: pathInRepo
+         value: pipelines/enterprise-contract.yaml
+       resolver: git
+       resourceKind: pipeline

@@ (root level) @@
# appstudio.redhat.com/v1beta2/IntegrationTestScenario/rhtas-tenant/rekor-search-enterprise-contract
! + one document added:
+   ---
+   apiVersion: appstudio.redhat.com/v1beta2
+   kind: IntegrationTestScenario
+   metadata:
+     name: rekor-search-enterprise-contract
+     namespace: rhtas-tenant
+     annotations:
+       test.appstudio.openshift.io/kind: enterprise-contract
+   spec:
+     application: rekor-search
+     resolverRef:
+       params:
+       - name: url
+         value: "https://github.com/konflux-ci/build-definitions"
+       - name: revision
+         value: main
+       - name: pathInRepo
+         value: pipelines/enterprise-contract.yaml
+       resolver: git
+       resourceKind: pipeline

📦 Artifacts: base-output.yaml, head-output.yaml, dyff-output.txt

Copy link
Member

@fghanmi fghanmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@osmman osmman merged commit 393bb7a into main Oct 21, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants